PMD Results

The following document contains the results of PMD 4.2.2.

Files

org/webmacro/Broker.java

Violation Line
Avoid empty if statements 315 - 321
These nested if statements could be combined 364 - 368

org/webmacro/Context.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 604

org/webmacro/directive/ArgsHolder.java

Violation Line
Unnecessary final modifier in final class 55 - 64
Unnecessary final modifier in final class 78 - 81
Unnecessary final modifier in final class 86 - 91
Unnecessary final modifier in final class 97 - 106
Unnecessary final modifier in final class 114 - 119

org/webmacro/directive/BeanDirective.java

Violation Line
Avoid empty catch blocks 292 - 294
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 324

org/webmacro/directive/DirectiveBuilder.java

Violation Line
An empty statement (semicolon) not part of a loop 237

org/webmacro/directive/DirectiveProvider.java

Violation Line
Unnecessary final modifier in final class 88 - 91
Unnecessary final modifier in final class 100 - 170
Avoid empty catch blocks 151 - 153
Unnecessary final modifier in final class 175 - 178

org/webmacro/directive/EvalDirective.java

Violation Line
Avoid empty catch blocks 151 - 154
Avoid empty catch blocks 169 - 172

org/webmacro/directive/IfDirective.java

Violation Line
Avoid empty if statements 178 - 180

org/webmacro/engine/Argument.java

Violation Line
Unnecessary final modifier in final class 51 - 54
Unnecessary final modifier in final class 59 - 62
Unnecessary final modifier in final class 69 - 75

org/webmacro/engine/Block.java

Violation Line
Unnecessary final modifier in final class 90 - 226
Unnecessary final modifier in final class 311 - 320
Unnecessary final modifier in final class 322 - 333
Unnecessary final modifier in final class 338 - 353

org/webmacro/engine/GlobalVariable.java

Violation Line
Unnecessary final modifier in final class 49 - 53
Unnecessary final modifier in final class 60 - 71
Unnecessary final modifier in final class 77 - 80

org/webmacro/engine/IntrospectionUtils.java

Violation Line
Avoid empty catch blocks 117 - 120

org/webmacro/engine/ListBuilder.java

Violation Line
Unnecessary final modifier in final class 50 - 61
Unnecessary final modifier in final class 63 - 72

org/webmacro/engine/MacroAdapter.java

Violation Line
Unnecessary final modifier in final class 53 - 56
Unnecessary final modifier in final class 61 - 64
Unnecessary final modifier in final class 69 - 73
Unnecessary final modifier in final class 84 - 99

org/webmacro/engine/NullBuilder.java

Violation Line
Unnecessary final modifier in final class 30 - 33

org/webmacro/engine/ParserProvider.java

Violation Line
Unnecessary final modifier in final class 60 - 111
Unnecessary final modifier in final class 113 - 123

org/webmacro/engine/PropertyOperatorCache.java

Violation Line
Unnecessary final modifier in final class 68 - 127
Unnecessary final modifier in final class 134 - 146
Unnecessary final modifier in final class 148 - 160
Unnecessary final modifier in final class 174 - 189
Unnecessary final modifier in final class 194 - 200
Unnecessary final modifier in final class 213 - 237
Unnecessary final modifier in final class 242 - 249
Unnecessary final modifier in final class 259 - 272
These nested if statements could be combined 680 - 697
Unnecessary final modifier in final class 872 - 883
Avoid empty catch blocks 936 - 939
Avoid empty catch blocks 976 - 979
Avoid empty catch blocks 980 - 983
Unnecessary final modifier in final class 1172 - 1185
Unnecessary final modifier in final class 1187 - 1201
Unnecessary final modifier in final class 1216 - 1229
Unnecessary final modifier in final class 1231 - 1235
Unnecessary final modifier in final class 1253 - 1256
Unnecessary final modifier in final class 1258 - 1301
Avoid empty catch blocks 1415 - 1418
Unnecessary final modifier in final class 1442 - 1445
Unnecessary final modifier in final class 1447 - 1450
Unnecessary final modifier in final class 1452 - 1456
Unnecessary final modifier in final class 1458 - 1464
Unnecessary final modifier in final class 1477 - 1480
Unnecessary final modifier in final class 1482 - 1485
Unnecessary final modifier in final class 1487 - 1493
Unnecessary final modifier in final class 1495 - 1501

org/webmacro/engine/PropertyVariable.java

Violation Line
Unnecessary final modifier in final class 49 - 53
Unnecessary final modifier in final class 60 - 70
Unnecessary final modifier in final class 76 - 79

org/webmacro/engine/QuotedStringBuilder.java

Violation Line
Unnecessary final modifier in final class 48 - 88
Unnecessary final modifier in final class 172 - 176

org/webmacro/engine/SimplePropertyVariable.java

Violation Line
Unnecessary final modifier in final class 50 - 54
Unnecessary final modifier in final class 61 - 71
Unnecessary final modifier in final class 77 - 80

org/webmacro/engine/StaticClassWrapper.java

Violation Line
Unnecessary final modifier in final class 41 - 44

org/webmacro/engine/StringMacroAdapter.java

Violation Line
Unnecessary final modifier in final class 46 - 49
Unnecessary final modifier in final class 59 - 62
Unnecessary final modifier in final class 67 - 71

org/webmacro/engine/UndefinedMacro.java

Violation Line
Unnecessary final modifier in final class 49 - 53
Unnecessary final modifier in final class 63 - 66
Unnecessary final modifier in final class 76 - 80

org/webmacro/parser/ASCII_CharStream.java

Violation Line
Unnecessary final modifier in final class 70 - 75
Unnecessary final modifier in final class 77 - 127
Unnecessary final modifier in final class 129 - 137
Unnecessary final modifier in final class 139 - 177
Unnecessary final modifier in final class 179 - 204
An empty statement (semicolon) not part of a loop 193
Unnecessary final modifier in final class 211 - 214
Unnecessary final modifier in final class 221 - 224
Unnecessary final modifier in final class 226 - 229
Unnecessary final modifier in final class 231 - 234
Unnecessary final modifier in final class 236 - 239
Unnecessary final modifier in final class 241 - 244
Unnecessary final modifier in final class 246 - 260
Unnecessary final modifier in final class 327 - 336
Unnecessary final modifier in final class 338 - 355

org/webmacro/parser/BackupCharStream.java

Violation Line
Unnecessary final modifier in final class 72 - 77
Unnecessary final modifier in final class 79 - 137
Unnecessary final modifier in final class 139 - 147
Unnecessary final modifier in final class 149 - 187
Unnecessary final modifier in final class 189 - 215
An empty statement (semicolon) not part of a loop 203
Unnecessary final modifier in final class 222 - 225
Unnecessary final modifier in final class 232 - 235
Unnecessary final modifier in final class 237 - 240
Unnecessary final modifier in final class 242 - 245
Unnecessary final modifier in final class 247 - 250
Unnecessary final modifier in final class 252 - 255
Unnecessary final modifier in final class 257 - 271
Unnecessary final modifier in final class 349 - 367
Unnecessary final modifier in final class 369 - 386

org/webmacro/parser/TokenMgrError.java

Violation Line
Overriding method merely calls super 118 - 120

org/webmacro/parser/WMParser_impl.java

Violation Line
An empty statement (semicolon) not part of a loop 138
These nested if statements could be combined 292 - 293
An empty statement (semicolon) not part of a loop 397
An empty statement (semicolon) not part of a loop 423
An empty statement (semicolon) not part of a loop 427
An empty statement (semicolon) not part of a loop 446
An empty statement (semicolon) not part of a loop 456
An empty statement (semicolon) not part of a loop 468
An empty statement (semicolon) not part of a loop 476
An empty statement (semicolon) not part of a loop 481
An empty statement (semicolon) not part of a loop 492
An empty statement (semicolon) not part of a loop 500
An empty statement (semicolon) not part of a loop 511
An empty statement (semicolon) not part of a loop 521
An empty statement (semicolon) not part of a loop 548
An empty statement (semicolon) not part of a loop 562
An empty statement (semicolon) not part of a loop 571
An empty statement (semicolon) not part of a loop 584
An empty statement (semicolon) not part of a loop 593
An empty statement (semicolon) not part of a loop 605
An empty statement (semicolon) not part of a loop 614
An empty statement (semicolon) not part of a loop 625
An empty statement (semicolon) not part of a loop 634
An empty statement (semicolon) not part of a loop 645
An empty statement (semicolon) not part of a loop 654
An empty statement (semicolon) not part of a loop 665
An empty statement (semicolon) not part of a loop 674
An empty statement (semicolon) not part of a loop 686
An empty statement (semicolon) not part of a loop 695
Do not use if statements that are always true or always false 698
These nested if statements could be combined 698 - 699
An empty statement (semicolon) not part of a loop 710
An empty statement (semicolon) not part of a loop 719
An empty statement (semicolon) not part of a loop 733
An empty statement (semicolon) not part of a loop 742
An empty statement (semicolon) not part of a loop 790
An empty statement (semicolon) not part of a loop 806
An empty statement (semicolon) not part of a loop 823
An empty statement (semicolon) not part of a loop 873
An empty statement (semicolon) not part of a loop 915
An empty statement (semicolon) not part of a loop 1013
An empty statement (semicolon) not part of a loop 1023
An empty statement (semicolon) not part of a loop 1046
An empty statement (semicolon) not part of a loop 1056
An empty statement (semicolon) not part of a loop 1079
An empty statement (semicolon) not part of a loop 1089
An empty statement (semicolon) not part of a loop 1096
An empty statement (semicolon) not part of a loop 1123
An empty statement (semicolon) not part of a loop 1133
An empty statement (semicolon) not part of a loop 1156
An empty statement (semicolon) not part of a loop 1166
An empty statement (semicolon) not part of a loop 1189
An empty statement (semicolon) not part of a loop 1199
An empty statement (semicolon) not part of a loop 1222
An empty statement (semicolon) not part of a loop 1232
An empty statement (semicolon) not part of a loop 1239
An empty statement (semicolon) not part of a loop 1267
An empty statement (semicolon) not part of a loop 1277
An empty statement (semicolon) not part of a loop 1310
An empty statement (semicolon) not part of a loop 1319
An empty statement (semicolon) not part of a loop 1326
An empty statement (semicolon) not part of a loop 1339
An empty statement (semicolon) not part of a loop 1348
An empty statement (semicolon) not part of a loop 1355
An empty statement (semicolon) not part of a loop 1383
An empty statement (semicolon) not part of a loop 1393
An empty statement (semicolon) not part of a loop 1400
An empty statement (semicolon) not part of a loop 1413
An empty statement (semicolon) not part of a loop 1423
An empty statement (semicolon) not part of a loop 1430
An empty statement (semicolon) not part of a loop 1436
An empty statement (semicolon) not part of a loop 1451
An empty statement (semicolon) not part of a loop 1471
An empty statement (semicolon) not part of a loop 1480
An empty statement (semicolon) not part of a loop 1518
An empty statement (semicolon) not part of a loop 1549
An empty statement (semicolon) not part of a loop 1559
An empty statement (semicolon) not part of a loop 1579
Do not use if statements that are always true or always false 1587
An empty statement (semicolon) not part of a loop 1599
An empty statement (semicolon) not part of a loop 1609
An empty statement (semicolon) not part of a loop 1629
Do not use if statements that are always true or always false 1637
An empty statement (semicolon) not part of a loop 1689
An empty statement (semicolon) not part of a loop 1698
An empty statement (semicolon) not part of a loop 1702
Do not use if statements that are always true or always false 1707
Do not use if statements that are always true or always false 1708
Do not use if statements that are always true or always false 1709
Do not use if statements that are always true or always false 1710
Do not use if statements that are always true or always false 1711
Do not use if statements that are always true or always false 1712
Do not use if statements that are always true or always false 1713
An empty statement (semicolon) not part of a loop 1725
An empty statement (semicolon) not part of a loop 1735
An empty statement (semicolon) not part of a loop 1744
An empty statement (semicolon) not part of a loop 1758
An empty statement (semicolon) not part of a loop 1768
An empty statement (semicolon) not part of a loop 1777
An empty statement (semicolon) not part of a loop 1813
An empty statement (semicolon) not part of a loop 1835
An empty statement (semicolon) not part of a loop 1991
An empty statement (semicolon) not part of a loop 2047
An empty statement (semicolon) not part of a loop 2060
An empty statement (semicolon) not part of a loop 2126
An empty statement (semicolon) not part of a loop 2172
An empty statement (semicolon) not part of a loop 2177
An empty statement (semicolon) not part of a loop 2225
An empty statement (semicolon) not part of a loop 2248
Avoid empty catch blocks 3182

org/webmacro/parser/WMParser_implTokenManager.java

Violation Line
These nested if statements could be combined 200 - 201
Do not start a literal by 0 unless it's an octal value 220
Do not start a literal by 0 unless it's an octal value 254
Do not start a literal by 0 unless it's an octal value 256
These nested if statements could be combined 333 - 334
Do not start a literal by 0 unless it's an octal value 361
Do not start a literal by 0 unless it's an octal value 395
Do not start a literal by 0 unless it's an octal value 397
Do not start a literal by 0 unless it's an octal value 482
Do not start a literal by 0 unless it's an octal value 484
These nested if statements could be combined 875 - 876
Do not start a literal by 0 unless it's an octal value 1004
Do not start a literal by 0 unless it's an octal value 1102
Do not start a literal by 0 unless it's an octal value 1104
These nested if statements could be combined 1180 - 1181
Do not start a literal by 0 unless it's an octal value 1208
Do not start a literal by 0 unless it's an octal value 1242
Do not start a literal by 0 unless it's an octal value 1244
Do not start a literal by 0 unless it's an octal value 1485
Do not start a literal by 0 unless it's an octal value 1496

org/webmacro/resource/BrokerTemplateProvider.java

Violation Line
Unnecessary final modifier in final class 56 - 59
Unnecessary final modifier in final class 61 - 66

org/webmacro/resource/BrokerTemplateProviderHelper.java

Violation Line
Unnecessary final modifier in final class 102 - 176
Unnecessary final modifier in final class 198 - 206

org/webmacro/resource/DelegatingTemplateProvider.java

Violation Line
These nested if statements could be combined 95 - 101

org/webmacro/resource/TemplateProvider.java

Violation Line
Avoid empty catch blocks 77 - 80
Unnecessary final modifier in final class 148 - 151
Unnecessary final modifier in final class 156 - 212
Unnecessary final modifier in final class 222 - 239

org/webmacro/resource/URLTemplate.java

Violation Line
Avoid empty catch blocks 203 - 205

org/webmacro/resource/URLTemplateProvider.java

Violation Line
Unnecessary final modifier in final class 174 - 177
Unnecessary final modifier in final class 224 - 228
Unnecessary final modifier in final class 239 - 269
Unnecessary final modifier in final class 296 - 300
Unnecessary final modifier in final class 302 - 329
Avoid empty catch blocks 324 - 326
Unnecessary final modifier in final class 336 - 400
Unnecessary final modifier in final class 464 - 475
Unnecessary final modifier in final class 488 - 519
These nested if statements could be combined 512 - 516
Unnecessary final modifier in final class 526 - 536
Unnecessary final modifier in final class 544 - 556

org/webmacro/resource/UrlProvider.java

Violation Line
Unnecessary final modifier in final class 65 - 68
Unnecessary final modifier in final class 88 - 168

org/webmacro/servlet/CGI_Impersonator.java

Violation Line
Unnecessary final modifier in final class 69 - 72
Unnecessary final modifier in final class 77 - 80
Unnecessary final modifier in final class 86 - 89
Unnecessary final modifier in final class 94 - 97
Unnecessary final modifier in final class 102 - 105
Unnecessary final modifier in final class 112 - 115
Unnecessary final modifier in final class 120 - 123
Unnecessary final modifier in final class 129 - 132
Unnecessary final modifier in final class 140 - 143
Unnecessary final modifier in final class 148 - 151
Unnecessary final modifier in final class 156 - 159
Unnecessary final modifier in final class 164 - 167
Unnecessary final modifier in final class 172 - 175
Unnecessary final modifier in final class 180 - 183
Unnecessary final modifier in final class 188 - 191
Unnecessary final modifier in final class 196 - 199
Unnecessary final modifier in final class 204 - 207
Unnecessary final modifier in final class 212 - 215
Unnecessary final modifier in final class 220 - 223

org/webmacro/servlet/CookieJar.java

Violation Line
Unnecessary final modifier in final class 54 - 68
Unnecessary final modifier in final class 74 - 78
Unnecessary final modifier in final class 83 - 94

org/webmacro/servlet/ErrorHandler.java

Violation Line
Unnecessary final modifier in final class 99 - 102

org/webmacro/servlet/Form.java

Violation Line
Unnecessary final modifier in final class 59 - 75
Unnecessary final modifier in final class 85 - 110
Unnecessary final modifier in final class 116 - 126
Unnecessary final modifier in final class 131 - 135
Unnecessary final modifier in final class 141 - 145
Unnecessary final modifier in final class 150 - 165

org/webmacro/servlet/FormList.java

Violation Line
Unnecessary final modifier in final class 54 - 64
Unnecessary final modifier in final class 69 - 73
Unnecessary final modifier in final class 78 - 82

org/webmacro/servlet/LocaleTool.java

Violation Line
Avoid empty catch blocks 136 - 138

org/webmacro/servlet/Servlet20Broker.java

Violation Line
Avoid empty catch blocks 192 - 194

org/webmacro/servlet/Servlet22Broker.java

Violation Line
Avoid empty catch blocks 291 - 293

org/webmacro/servlet/WMServlet.java

Violation Line
Avoid empty catch blocks 532 - 535

org/webmacro/util/ArrayIterator.java

Violation Line
Unnecessary final modifier in final class 49 - 52
Unnecessary final modifier in final class 58 - 68
Unnecessary final modifier in final class 73 - 76

org/webmacro/util/Base64.java

Violation Line
Unnecessary final modifier in final class 47 - 50
Unnecessary final modifier in final class 55 - 58
Unnecessary final modifier in final class 63 - 144
Unnecessary final modifier in final class 149 - 221

org/webmacro/util/ByteBufferOutputStream.java

Violation Line
Unnecessary final modifier in final class 96 - 111

org/webmacro/util/DictionaryTool.java

Violation Line
Unnecessary final modifier in final class 40 - 55
Unnecessary final modifier in final class 73 - 76
Unnecessary final modifier in final class 81 - 84
Unnecessary final modifier in final class 89 - 92
Unnecessary final modifier in final class 97 - 100
Unnecessary final modifier in final class 105 - 108
Unnecessary final modifier in final class 113 - 116
Unnecessary final modifier in final class 121 - 124

org/webmacro/util/EncodingCache.java

Violation Line
An empty statement (semicolon) not part of a loop 164
An empty statement (semicolon) not part of a loop 223

org/webmacro/util/EnumIterator.java

Violation Line
Unnecessary final modifier in final class 52 - 55
Unnecessary final modifier in final class 63 - 72
Unnecessary final modifier in final class 78 - 81

org/webmacro/util/Instantiator.java

Violation Line
Avoid empty catch blocks 207 - 210

org/webmacro/util/PrimitiveArrayIterator.java

Violation Line
Unnecessary final modifier in final class 56 - 59
Unnecessary final modifier in final class 65 - 75
Unnecessary final modifier in final class 80 - 83

org/webmacro/util/Settings.java

Violation Line
Avoid empty catch blocks 123 - 126
An empty statement (semicolon) not part of a loop 127